fix: use script lang regex from svelte compiler #1028
Merged
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
approved these changes
Nov 21, 2024
|
good to go as a quick fix but we really need to do sth about the regex in general |
dominikg
approved these changes
Nov 21, 2024
bluwy
pushed a commit
that referenced
this pull request
Nov 21, 2024
|
I've merged this PR to |
|
IMO in an ideal world the svelte compiler would forward the detected language. If this was ever implemented we could use that and keep the regex as a fallback for older svelte versions. |
|
I just tried to merge again and it seems to work now, but it created an empty commit in |
bluwy
pushed a commit
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for sveltejs/svelte#14384
I just copied the svelte compiler's regex and adjusted the match array index.
Question: is it possible to directly use the regex from the svelte compiler?